[dancer-users] Some questions about Logger and format_message in Dancer2

[Sawyer X]

On Mon, Nov 10, 2014 at 12:46 PM, Lennart Hengstmengel <lennart at tevreden.nl>
wrote:

> Hi Sawyer,


Hey. :)


>
>
> On 08-11-14 12:15, Sawyer X wrote:
>
>
>> Submit the PR and let's check it out.
>>
>>
> Thanks for the useful feedback! I submitted a PR at
> https://github.com/PerlDancer/Dancer2/pull/760


Wonderful!

I've seen it but haven't had time to review it. I hope to do so today.


>
> There's one thing I encountered and I'm not sure whether I did this right.
> In the code there was: setting('charset'), which triggered an error
> (undefined function). So I changed it to $self->config->{'charset'} however
> $self->config appears to be an empty hashref. I expected it to contain the
> app config (with at least a key 'charset' as that is in the config.yml). Is
> this assumption correct? If not, what is the best way to get access to the
> app config / charset setting?
>

Since the internals are... well, internals, they should not be calling the
DSL. DSL is for end-users.

I'll take a look at why it's missing. Perhaps it's not available yet. I'll
reply on the issue!

Thanks again for the pull request!

Sawyer.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.preshweb.co.uk/pipermail/dancer-users/attachments/20141112/d787edc5/attachment.html>