On Sep 30, 2011, at 7:24 AM, Nick Knutov wrote:

Hello,

Looks interesting, but I personally very dislike Moose/Mouse/Moo syntax. Will it be possible to write plugins for Dancer2 without Moo?

I too detest Moose, but hadn't seen Moo, which now looks very interesting. It seems to be in the spirit of ::Tiny, and I love all ::Tiny (pretty much exclusively use Template::Tiny). sidenote -- Why I dislike Moose: I never installed Moose. But, I ended up getting Moose because I installed something else (I think it was an app based on Catalyst). So, I wanted a croissant... and suddenly I saw all the ingredients in the grocery store, and all the parts of a kitchen, and a house and a factory flying by me... WTF! Maybe it is just perception. If Moose had installed silently, and I had never known about it, I wouldn't have been bothered by it. Lesson: keep Dancer lightweight. Every change in its core should be a change that has a legitimate reason, not gratuitous.

30.09.2011 16:47, sukria пишет:

...

Hi there,

I am very glad and proud to announce here that I've came up with a prototype of dancer2 that pleases me enough to be advertised.

-*- https://github.com/sukria/dancer2 -*-

dancer2 is a complete rewrite of Dancer aiming at providing the same awesomeness with the following major changes:

- no more globals in the core - 100% object-oriented backend (based on Moo) - better scoping for sub-applications - better design (no more encapsulation violations, Law of Demeter, ...)

The prototype I've pushed to GitHub currently covers ~80% of the DSL of Dancer. It's able to run simple applications (it can run the PerlDancer.org website for instance).

Of course, with your real-life applications, it will break in many places in this current shape, and this is where you can help. I'd like to have as many reports as possible regarding upgrades tests.

You can test very easily your app with dancer2:

$ git clone http://github.com/sukria/dancer2.git $ cd YOUR_APP $ perl -I../dancer2/lib bin/app.pl

Also, important to know: most of the plugins may not be working well.

Thanks a lot ;)

On Fri, Sep 30, 2011 at 10:12 AM, sukria <sukria@sukria.net> wrote:

Anyway, my announcement was sent in order to get feedback about application upgrades (from Dancer 1 to 2), so please, dont turn this into a discussion about Moose/Mouse/Moo/Mo/M ;)

Questions if you have a moment:

- Is the object of this to be 100% back compatible? - Are we going to change how we do plugins? - Considering this is a rewrite, is there any augmentation as part of this? (New functionality, or just better?) Thanks sukria! meraxes -- dave.s.doyle@gmail.com

Alexis Sukrieh wrote, On 10/03/2011 12:30 PM:

2011/10/3 Assaf Gordon <gordon@cshl.edu>:

...

Changing the template engine to "template_toolkit" simply changes the error message to: Yeah, the syntax changed, you should do the following in your config:

template: "toolkit"

That solved it. A minor difference (from Dancer 1): In the "index.tt" template, there's a sidebar which contains: ===== <h3>Your application's environment</h3> <ul> <li>Location: <code>/home/gordon/projects/dancer_test/MyFirstApp</code></li> <li>Template engine: <code><% settings.template %></code></li> <li>Logger: <code><% settings.logger %></code></li> <li>Environment: <code><% settings.environment %></code></li> </ul> ===== With Dancer 1, the output is : === Your application's environment Location: /home/gordon/projects/dancer_test/MyFirstApp Template engine: simple Logger: console Environment: development === With Dancer 2, the output is: === Your application's environment Location: /home/gordon/projects/dancer_test/MyFirstApp Template engine: Dancer::Template::Toolkit=HASH(0x188dcb8) Logger: Dancer::Logger::Console=HASH(0x1602758) Environment: === That is - with the "HASH(0x188dcb8)" part of the engine & logger objects. Also - it seems "environment" is not set, but perhaps that's another (updated) configuration option that I'm missing.

[...]

...

Problem 2: Cannot combine a prefix (/testme) with a regular expression ((?-xism:.*)) at (eval 72) line 74

Hmm, this looks to be a regression, but can you make sure it actuallt works under Dancer1 ?

Yes, it works with Dancer1. Here's how to reproduce: ========= ## ## Create a new application ## $ dancer -a d2test4 [...] $ cd d2test4/ ## ## Add a "prefix" statement ## $ sed -i '6iprefix "/testme";' lib/d2test4.pm ## ## show the updated application ## $ cat lib/d2test4.pm package d2test4; use Dancer ':syntax'; our $VERSION = '0.1'; prefix "/testme"; get '/' => sub { template 'index'; }; true; ## ## Run with Dancer 1 ## $ ./bin/app.pl [15837] core @0.000008> loading Dancer::Handler::Standalone handler in /usr/local/share/perl/5.12.4/Dancer/Handler.pm l. 41 [15837] core @0.000163> loading handler 'Dancer::Handler::Standalone' in /usr/local/share/perl/5.12.4/Dancer.pm l. 366

...

Dancer 1.3072 server 15837 listening on http://0.0.0.0:3000 == Entering the development dance floor ... [15837] core @0.000123> request: GET /testme/ from 127.0.0.1 in /usr/local/share/perl/5.12.4/Dancer/Handler.pm l. 52 [15837] core @0.000502> [hit #1]trying to match `/testme/' against /(?-xism:^(?-xism:^\/testme(?:\/)?$)$)/ in /usr/local/share/perl/5.12.4/Dancer/Route.pm l. 78 [15837] core @0.000641> [hit #1] --> got 1 in /usr/local/share/perl/5.12.4/Dancer/Route.pm l. 95 [15837] core @0.006332> [hit #1]response: 200 in /usr/local/share/perl/5.12.4/Dancer/Handler.pm l. 167 ^C

## ## Run with Dancer 2 ## $ perl -I /home/gordon/sources/dancer2/lib ./bin/app.pl core: binding app to main core: binding app to d2test4 core: [d2test4] running 'prefix' with /testme core: [d2test4] running 'get' with /, CODE(0x2b082b8) core: [d2test4] running 'true' with core: [main] running 'dance' with Cannot combine a prefix (/testme) with a regular expression ((?-xism:.*)) at (eval 72) line 74 ====== I did not change the "config.yml" file with the correct template syntax, but I assume it is not relevant for this behavior. -gordon

On 10/03/2011 09:43 PM, David Precious wrote:

I'm not sure I really like the change from Dancer::Template::TemplateToolkit to Dancer::Template::Toolkit; the logical layout is a module under the Dancer::Template namespace named after the templating engine it uses, i.e. "Dancer::Template::EngineName" - e.g. Dancer::Template::TemplateToolkit, Dancer::Template::HTMLTemplate, etc. Using just "toolkit" seems a bit wrong to me - what do you think?

I second that. The full name of the template engine is "Template Toolkit", so using just "toolkit" seems somewhat inconsistent.

It also seems a bit pointless lowercasing the engine name - we could just make it so the engine name you provide is whatever you see after Dancer::Template:: with no translation at all - so TemplateToolkit is Dancer::Template::TemplateToolkit, HTMLTemplate is Dancer::Template::HTMLTemplate, etc etc.

Yeah, I think this might also be good for consistency. The plugins configuration section uses the actual (non-lowercase) plugin names, so the same rule could be applied to template engines. -- Michal Wojciechowski http://odyniec.net/ | http://search.cpan.org/~odyniec/

2011/10/3 David Precious <davidp@preshweb.co.uk>:

On Monday 03 October 2011 17:30:37 Alexis Sukrieh wrote:

...

...

Changing the template engine to "template_toolkit" simply changes the error message to: Yeah, the syntax changed, you should do the following in your config:

template: "toolkit"

I'm not sure I really like the change from Dancer::Template::TemplateToolkit to Dancer::Template::Toolkit; the logical layout is a module under the Dancer::Template namespace named after the templating engine it uses, i.e. "Dancer::Template::EngineName" - e.g. Dancer::Template::TemplateToolkit, Dancer::Template::HTMLTemplate, etc.  Using just "toolkit" seems a bit wrong to me - what do you think?

Fair enough, I'll change it back to TemplateToolkit. Also, I plan to remove our Template::Simple engine in dancer2 in favor of Template::Tiny.

2011/10/3 Assaf Gordon <gordon@cshl.edu>:

sukria wrote, On 09/30/2011 06:47 AM:

...

Problem 2: ========== 1. created a new Dancer application"  $ dancer -a d2test3  $ cd d2test3

2. Added a single line to "./lib/d2test3.pm" (with "prefix "/testme";"):  $ sed -i '6iprefix "/testme";' lib/d2test3.pm

3. Run with new Dancer, I get the following error: Cannot combine a prefix (/testme) with a regular expression ((?-xism:.*)) at (eval 72) line 74

This has been fixed here: https://github.com/sukria/dancer2/commit/f56e4f7a5e5880705162747d7cf9794f45d... Thanks for the report!

Thanks for all these tests, I'm going to fix that. 2011/10/3 Assaf Gordon <gordon@cshl.edu>:

Hi,

another problem: POST request with parameters hangs.

Steps to reproduce: ==== ## New dancer app $ dancer -a d2test5post $ cd d2test5post/

## Change the "GET" to a "POST": $ sed -i '/^get/s/^get/post/' lib/d2test5post.pm $ cat lib/d2test5post.pm package d2test5post; use Dancer ':syntax';

our $VERSION = '0.1';

post '/' => sub {    template 'index'; };

true;

## run the application with Dancer 1: $ ./bin/app.pl

## ## In a new terminal, run the following commands: ##

## Access the app with "GET" - this fails (as expected). $ curl http://localhost:3000/ [ 404 response ]

## Access the app with "POST" (no parameters) - works OK $ curl -X POST http://localhost:3000/ [ ... ]

## Access the app with "POST" (and parameters) - works OK $ curl -X POST -d name=foobar http://localhost:3000/ [ ... ]

## ## Now test with Dancer 2 ##

## change the 'config.yml' and the templates to use Dancer2's TT $ sed -i '/^template:/s/".*"/"toolkit"/' config.yml $ sed -i 's/<%/[%/g' views/index.tt $ sed -i 's/%>/%]/g' views/index.tt $ sed -i 's/<%/[%/g' views/layouts/main.tt $ sed -i 's/%>/%]/g' views/layouts/main.tt

## Run with Dancer2 $ perl -I ../sources/dancer2/lib ./bin/app.pl

## ## In a new terminal, run the following commands ##

## Access the app with "GET" - this fails (as expected). $ curl http://localhost:3000/ [ 404 response ]

## Access the app with "POST" (no parameters) - works OK $ curl -X POST http://localhost:3000/ [ ... ]

## Access the app with "POST" (and parameters) - FAILS - the request hangs, BEFORE even reaching my 'post' handler code. $ curl -X POST -d name=foobar http://localhost:3000/ [ XXXX - Stuck - XXXX ]

==================

regards,  -gordon

Hello Alexis, I'm still getting this behavior (POST with parameters is stuck) with the latest dancer2. But I have more details. Alexis Sukrieh wrote, On 10/08/11 05:54:

2011/10/3 Assaf Gordon <gordon@cshl.edu>:

...

## Access the app with "POST" (and parameters) - FAILS - the request hangs, BEFORE even reaching my 'post' handler code. $ curl -X POST -d name=foobar http://localhost:3000/ [ XXXX - Stuck - XXXX ]

I can't reproduce that. Here is what I did:

$ curl -I -X POST http://0:3000/ HTTP/1.0 200 OK

The missing part is adding POST parameters, with the following command: $ curl -I -X POST -d "hello=world" http://0:3000/ Here's what happens in my setup, to the best of my ability to debug dancer2: 1. Request arrives (after some trials and tribulations) to "Dancer::Core::Dispatcher->dispatch()" which finds the appropriate route. 2. "Dispatch()" runs: my $http_method = lc $context->request->method; but $context->request DOES NOT exist, so the "moo" auto-builder thingy calls "Dancer::Core::Context::_build_request". 3. A new Dancer::Core::Request object is created, goes to "Dancer::Core::Request->BUILD". Eventually calls "$self->_build_params()". 4. "Dancer::Core::Request->_build_params()" calls "_parse_post_params()" 5. "Dancer::Core::Request->_parse_post_params()" calls "_read_to_end()" 6. "Dancer::Core::Request->_read_to_end()" looks like this: ================ sub _read_to_end { my ($self) = @_; my $content_length = $self->content_length; return unless $self->_has_something_to_read(); if ($content_length > 0) { while (my $buffer = $self->_read()) { $self->{body} .= $buffer; $self->{_http_body}->add($buffer); } } return $self->{body}; } =============== I assume in your testing (without POST parameters), "content_length" was zero, and so nothing is read, and the function returns undef. In my case, "content_length" is the length of the POST parameters (e.g. "hello=world" = 11 characters). So it calls "$self->_read()". 7. "read_()" looks like this (without my sprinkled "warn" statements): =================== sub _read { my ($self,) = @_; my $remaining = $self->content_length - $self->{_read_position}; warn "#### remaining = $remaining"; my $maxlength = $self->{_chunk_size}; warn "#### maxlength = $maxlength"; return if ($remaining <= 0); my $readlen = ($remaining > $maxlength) ? $maxlength : $remaining; warn "#### readlen = $readlen"; my $buffer; my $rc; warn "##### before read"; warn "###### input_handle = " . dump($self->input_handle) ; $rc = $self->input_handle->read($buffer, $readlen); warn "##### after read"; if (defined $rc) { $self->{_read_position} += $rc; return $buffer; } else { croak "Unknown error reading input: $!"; } } =================== And Dancer2 is stuck in the: $rc = $self->input_handle->read($buffer, $readlen); Statement, unable to read the expected number of characters. The printed output is: ======== #### remaining = 11 at /home/gordon/sources/dancer2/lib/Dancer/Core/Request.pm line 552, <DATA> line 16. #### maxlength = 4096 at /home/gordon/sources/dancer2/lib/Dancer/Core/Request.pm line 554, <DATA> line 16. #### readlen = 11 at /home/gordon/sources/dancer2/lib/Dancer/Core/Request.pm line 559, <DATA> line 16. ##### before read at /home/gordon/sources/dancer2/lib/Dancer/Core/Request.pm line 563, <DATA> line 16. ###### input_handle = do { require Symbol; bless(Symbol::gensym(), "FileHandle"); } at /home/gordon/sources/dancer2/lib/Dancer/Core/Request.pm line 564, <DATA> line 16. ======== Because the "read" function never returns. Not sure if this is a problem in my setup or in dancer2, but it's reproducible every time. regards, -assaf.

On 10/04/2011 04:55 PM, Alexis Sukrieh wrote:

2011/10/4 Stefan Hornburg (Racke)<racke@linuxia.de>:

...

On 09/30/2011 06:47 AM, sukria wrote:

How do I port a template engine to dancer2? Just implementing the context method?

You just have to consume the role Dancer::Core::Role::Template, and then, implement the render method.

See Toolkit.pm, it's a good example of how to do it: https://github.com/sukria/dancer2/blob/master/lib/Dancer/Template/Toolkit.pm

OK, that was indeed fairly easy: https://github.com/racke/Template-Flute/commit/87c3a73b0f0c2a4c8cbeb750c42a5... Regards Racke -- LinuXia Systems => http://www.linuxia.de/ Expert Interchange Consulting and System Administration ICDEVGROUP => http://www.icdevgroup.org/ Interchange Development Team