[Dancer-users] Failing tests for sessions during Dancer upgrade from 1.3050 to 1.3060

[Stefan Oberwahrenbrock]

Hello fellow dancers,

trying to upgrade Dancer from 1.3050 to 1.3060 on my Debian 5.0 system, 
I got an error message during "make test" when it came to run tests on 
Dancer sessions. The relevant output was this:

----<start output>----

Failed Test            Stat Wstat Total Fail  List of Failed
-------------------------------------------------------------------------------
t/08_session/05_yaml.t    1   256    12    1  11


t/08_session/05_yaml...........................NOK 11/12
#   Failed test 'session dir was not recreated'
#   at t/08_session/05_yaml.t line 58.
#                   'Error in tempfile() using 
/tmp/LGNdqcYb9t/sessions/714935461137124675383662533356367296.XXXXXXXX: 
Parent directory (/tmp/LGNdqcYb9t/sessions/) is not a directory at 
/root/.cpan/build/Dancer-1.3060-R45rPb/blib/lib/Dancer/Session/YAML.pm 
line 90
# '
#     doesn't match '(?-xism:Parent directory .* does not exist)'
# Looks like you failed 1 test of 12.
t/08_session/05_yaml...........................dubious
         Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 11
         Failed 1/12 tests, 91.67% okay

----<stop output>----

I have to admit, that I don't have any practical knowledge on writing 
tests - up till now, I only used distributions and never wrote one :-) 
Trying to interpretate the message it seemed to me, that in the above 
mentioned message, the expected output just differed a little bit from 
the one, that really occured during the test ("is not a directory" vs. 
"does not exist"). Optimistically I changed line 58 of 
"t/08_session/05_yaml.t"
from:
like ($@, qr/Parent directory .* does not exist/, "session dir was not 
recreated");
to:
like ($@, qr/Parent directory .* is not a directory/, "session dir was 
not recreated");

After this alteration, "make test" and "make install" just worked 
without any errors - Dancer 1.3060 is now available on my system. It 
would be nice, if anyone could comment my approach - I am not sure, if I 
did the right thing.

Thanks and greetings,
Stefan