Dancer2::Plugin::REST breaks tests
Hi, i know there's already an issue open on CPAN RT about this problem, but are there news about a new release of the package? I spent some time looking into the problem, first fail should depends by the before hook in Dancer2::Core::Response. Comments here say that "All serializers return byte strings". I'm a bit curious about this... why was implemented this way considering that Serializer are something like YAML and JSON? Second problem is just about new Dancer2 server (I solved something similar here: http://perlishscrewdriver.blogspot.it/2014/05/all-releases-come-with-bug.htm...). -- Cymon Coniglio domina, http://www.therabbit.it
On 4/06/2014 10:10 am, Cymon wrote: > I know there's already an issue open on CPAN RT about this problem, but > are there news about a new release of the package? There is a Pr that updates the code/tests to pass against the Dancer2 release. Hopefully Yanick has time to review/release. > I spent some time looking into the problem, first fail should depends > by the before hook in Dancer2::Core::Response. Comments here say that > "All serializers return byte strings". I'm a bit curious about this... > why was implemented this way considering that Serializer are something > like YAML and JSON? The HTTP protocol deals with octects, so the request and response data has to be decoded/encoded somewhere. There is also no consistency between the available serializers' deserialize/serialize methods; take the various YAML modules as an example: * YAML::Dump() gives characters * YAML::XS::Dump gives octets [ Which is why Dancer2 no longer uses YAML::Any ]. Since you need to end up with octets (or byte strings) in the response body, it made sense to define that as the expectation when something was serialized. Hope that helps, Russell.
On Wed, Jun 04, 2014 at 08:25:57PM +1000, Russell Jenkins wrote:
Hopefully Yanick has time to review/release.
*poof* Somebody voiced my name? :-) I'll try to do the release dance tonight. ... and, as part of a bigger resolution, be more often on irc, so that peeps can kick me awake from time to time. :-) Joy, `/anick --
Il giorno Thu, 5 Jun 2014 09:46:23 -0400 Yanick Champoux <yanick@babyl.dyndns.org> ha scritto:
On Wed, Jun 04, 2014 at 08:25:57PM +1000, Russell Jenkins wrote:
Hopefully Yanick has time to review/release.
The libations were adequate, as was the summoning spell. A new version of Dancer2::P::REST is on its way to CPAN. :-)
You're great! (and if you need I can help you cleaning the altar) -- Cymon http://perlishscrewdriver.blogspot.com
On 14-06-05 05:09 PM, Cymon wrote:
Il giorno Thu, 5 Jun 2014 09:46:23 -0400 Yanick Champoux <yanick@babyl.dyndns.org> ha scritto:
On Wed, Jun 04, 2014 at 08:25:57PM +1000, Russell Jenkins wrote:
Hopefully Yanick has time to review/release.
The libations were adequate, as was the summoning spell. A new version of Dancer2::P::REST is on its way to CPAN. :-)
You're great!
Heh. Thanks. but let's wait for the results of CPANTesters before making that official, shall we? ;-) Joy, `/anick
participants (3)
-
Cymon -
Russell Jenkins -
Yanick Champoux