Updates to Dancer2::Plugin::Auth::Extensible
Hi guys, I mentioned a while ago that I was hoping to add features into Dancer2::Plugin::Auth::Extensible from https://github.com/abeverley/libdancer2-plugin-auth-complete-perl I'm going to hopefully look at this properly tomorrow, with the aim to migrate one of my projects across. This is just a heads-up, as I'd like to get this done pretty quickly. As a taster, I'm hoping to add the following functionality: * Password resets * Generate fixed passwords * DBIC support * Ability to update user details (providing backend supports it) Does anyone have any immediate comments on the above? Presumably the best thing for me to do is create PRs in Github? Thanks, Andy
On 02/15/2015 11:50 PM, Andrew Beverley wrote:
Hi guys,
I mentioned a while ago that I was hoping to add features into Dancer2::Plugin::Auth::Extensible from https://github.com/abeverley/libdancer2-plugin-auth-complete-perl
I'm going to hopefully look at this properly tomorrow, with the aim to migrate one of my projects across. This is just a heads-up, as I'd like to get this done pretty quickly. As a taster, I'm hoping to add the following functionality:
* Password resets * Generate fixed passwords * DBIC support * Ability to update user details (providing backend supports it)
Does anyone have any immediate comments on the above? Presumably the best thing for me to do is create PRs in Github?
PRs in Github are definitely a good way :-). Regards Racke -- Modern Perl, Dancer and eCommerce consulting.
On Mon, 2015-02-16 at 08:41 +0100, Stefan Hornburg (Racke) wrote:
Does anyone have any immediate comments on the above? Presumably the best thing for me to do is create PRs in Github?
PRs in Github are definitely a good way :-).
Great, will do. Will you have any time to look at them over the next couple of days, even if it's just some initial comments? Thanks, Andy
On 02/16/2015 12:04 PM, Andrew Beverley wrote:
On Mon, 2015-02-16 at 08:41 +0100, Stefan Hornburg (Racke) wrote:
Does anyone have any immediate comments on the above? Presumably the best thing for me to do is create PRs in Github?
PRs in Github are definitely a good way :-).
Great, will do. Will you have any time to look at them over the next couple of days, even if it's just some initial comments?
Sure. I'm on the road Tuesday and Wednesday, so I might take a bit. Regards Racke -- Modern Perl, Dancer and eCommerce consulting.
On Mon, 2015-02-16 at 08:41 +0100, Stefan Hornburg (Racke) wrote:
PRs in Github are definitely a good way :-).
So, I've done my first PR, which is actually a result of my inability to write a config file ;-) https://github.com/racke/Dancer2-Plugin-Auth-Extensible/pull/6
On Mon, 16 Feb 2015 13:11:42 +0000 Andrew Beverley <andy@andybev.com> wrote:
On Mon, 2015-02-16 at 08:41 +0100, Stefan Hornburg (Racke) wrote:
PRs in Github are definitely a good way :-).
So, I've done my first PR, which is actually a result of my inability to write a config file ;-)
https://github.com/racke/Dancer2-Plugin-Auth-Extensible/pull/6
Awesome - good call - if it's tripped you up, it probably has, or will, cause others trouble too! One thing I'd really like is to see DPAE for D1 & D2 merged into a single repo/codebase as we have for D::P::Database, with a shared "core" and D1 and D2 "wrappers". Well, actually, what I'd *really* like is a univeral D1/D2 compatible plugin architecture, perhaps as a Dancer::Plugin::Universal base class that provides the same API to modules regardless of the Dancer version they're running under, and use that - there's been talk of doing such a thing, but I haven't had time to try it, and, as far as I know, neither have others.
On Mon, 2015-02-16 at 13:30 +0000, David Precious wrote:
One thing I'd really like is to see DPAE for D1 & D2 merged into a single repo/codebase as we have for D::P::Database, with a shared "core" and D1 and D2 "wrappers".
I did look at this a while ago before DPAE was available for D2. The problem is that there is D2-specific code in a lot of the module files. For example, in most providers you have something like: use Dancer2::Plugin::Database; use Dancer2 qw(:syntax); Is it possible to avoid that somehow? Or maybe this is the only way to go:
Well, actually, what I'd *really* like is a univeral D1/D2 compatible plugin architecture, perhaps as a Dancer::Plugin::Universal base class that provides the same API to modules regardless of the Dancer version they're running under, and use that - there's been talk of doing such a thing, but I haven't had time to try it, and, as far as I know, neither have others.
On Sun, 15 Feb 2015 22:50:28 +0000 Andrew Beverley <andy@andybev.com> wrote:
Hi guys,
I mentioned a while ago that I was hoping to add features into Dancer2::Plugin::Auth::Extensible [...] I'm hoping to add the following functionality:
* Password resets * Generate fixed passwords * DBIC support * Ability to update user details (providing backend supports it)
Does anyone have any immediate comments on the above?
Immediate comments: AWESOME! :D
Presumably the best thing for me to do is create PRs in Github?
Yep, that's the best way - I'll watch out for them and try to set some time aside to eyeball them, I'm sure others will too (I saw Stefan already kindly raise his hand :) )
On Mon, 2015-02-16 at 11:59 +0000, David Precious wrote:
Does anyone have any immediate comments on the above?
Immediate comments: AWESOME! :D
Presumably the best thing for me to do is create PRs in Github?
Yep, that's the best way - I'll watch out for them and try to set some time aside to eyeball them, I'm sure others will too (I saw Stefan already kindly raise his hand :) )
Awesome, thanks! I'll hopefully create them over the next couple of days.
On Sun, 2015-02-15 at 22:50 +0000, Andrew Beverley wrote:
I mentioned a while ago that I was hoping to add features into Dancer2::Plugin::Auth::Extensible from https://github.com/abeverley/libdancer2-plugin-auth-complete-perl
I'm going to hopefully look at this properly tomorrow, with the aim to migrate one of my projects across. This is just a heads-up, as I'd like to get this done pretty quickly. As a taster, I'm hoping to add the following functionality:
* Password resets * Generate fixed passwords * DBIC support * Ability to update user details (providing backend supports it)
Okay, so this has come to a grinding halt. I started with DBIC support (essential for me before moving onto other things), but having just tried myself and then read through the archives, there are some issues with the plugin architecture that will make this difficult. I'll follow-up to one of the other posts in a moment. Andy
On Sun, 2015-02-15 at 22:50 +0000, Andrew Beverley wrote:
Hi guys,
I mentioned a while ago that I was hoping to add features into Dancer2::Plugin::Auth::Extensible from https://github.com/abeverley/libdancer2-plugin-auth-complete-perl
I'm going to hopefully look at this properly tomorrow, with the aim to migrate one of my projects across. This is just a heads-up, as I'd like to get this done pretty quickly. As a taster, I'm hoping to add the following functionality:
* Password resets * Generate fixed passwords * DBIC support * Ability to update user details (providing backend supports it)
So, I've finally done most of this. Racke is kindly reviewing it for me already, but I'd appreciate input from anyone else as well (Big Presh?). The full PR is at the following link. There is rather a lot in the one submission (over a bunch of commits) as a lot of the functionality depends on each other. https://github.com/PerlDancer/Dancer2-Plugin-Auth-Extensible/pull/10 For an overview, see the full proposed documentation at the following link: http://files.andybev.com/dpae.html Thanks, Andy
participants (3)
-
Andrew Beverley -
David Precious -
Stefan Hornburg (Racke)