Dancer::Session and cookie path of session cookie
Hi David, hi Dancer users, as talked in mid of December on irc.perl.org/#dancer I had some trouble with Dancer::Session::Cookie and the cookie path. I used 'session_cookie_path' set to a restricted area of a dancer app (requirement - don't ask), but on some circumstances the path was used or not. Later I figured out that Dancer::Session forces cookie rewrite using Dancer::Session::Abstract->write_session_id and when a session key/value was updated, Dancer::Session::Cookie->flush uses it's own cookie update mechanism. First I added the ability of restricting session cookie path to Dancer::Session::Abstract (and fix some function calls into methods). Then I forgot to install the fix and search for some hours the test failure in upated Dancer::Session::Cookie. This mail includes the patches for Dancer itself - follow up mail includes the patch for Dancer-Session-Cookie dist. Would be great if you could review and/or apply or find someone who could. Thanks in advance, Jens PS: Happy New Year, everyone!
On 27.12.12 17:14, Jens Rehsack wrote:
Hi David, hi Dancer users,
as talked in mid of December on irc.perl.org/#dancer I had some trouble with Dancer::Session::Cookie and the cookie path.
I used 'session_cookie_path' set to a restricted area of a dancer app (requirement - don't ask), but on some circumstances the path was used or not.
Later I figured out that Dancer::Session forces cookie rewrite using Dancer::Session::Abstract->write_session_id and when a session key/value was updated, Dancer::Session::Cookie->flush uses it's own cookie update mechanism.
First I added the ability of restricting session cookie path to Dancer::Session::Abstract (and fix some function calls into methods). Then I forgot to install the fix and search for some hours the test failure in upated Dancer::Session::Cookie.
This mail includes the patches for Dancer itself - follow up mail includes the patch for Dancer-Session-Cookie dist.
Would be great if you could review and/or apply or find someone who could.
Thanks in advance, Jens
PS: Happy New Year, everyone!
-- Jens Rehsack
I'm also interested in getting Dancer::Session::Cookie ported to Dancer 2. I'd be willing to help as co-maintainer if current maintainers are short on tuits. David On Thu, Dec 27, 2012 at 11:14 AM, Jens Rehsack <rehsack@cpan.org> wrote:
Hi David, hi Dancer users,
as talked in mid of December on irc.perl.org/#dancer I had some trouble with Dancer::Session::Cookie and the cookie path.
I used 'session_cookie_path' set to a restricted area of a dancer app (requirement - don't ask), but on some circumstances the path was used or not.
Later I figured out that Dancer::Session forces cookie rewrite using Dancer::Session::Abstract->write_session_id and when a session key/value was updated, Dancer::Session::Cookie->flush uses it's own cookie update mechanism.
First I added the ability of restricting session cookie path to Dancer::Session::Abstract (and fix some function calls into methods). Then I forgot to install the fix and search for some hours the test failure in upated Dancer::Session::Cookie.
This mail includes the patches for Dancer itself - follow up mail includes the patch for Dancer-Session-Cookie dist.
Would be great if you could review and/or apply or find someone who could.
Thanks in advance, Jens
PS: Happy New Year, everyone!
-- David Golden <dagolden@cpan.org> Take back your inbox! → http://www.bunchmail.com/ Twitter/IRC: @xdg
On 27.12.12 22:25, David Golden wrote:
On Thu, Dec 27, 2012 at 11:14 AM, Jens Rehsack <rehsack@cpan.org> wrote:
Hi David, hi Dancer users,
as talked in mid of December on irc.perl.org/#dancer I had some trouble with Dancer::Session::Cookie and the cookie path.
I used 'session_cookie_path' set to a restricted area of a dancer app (requirement - don't ask), but on some circumstances the path was used or not.
Later I figured out that Dancer::Session forces cookie rewrite using Dancer::Session::Abstract->write_session_id and when a session key/value was updated, Dancer::Session::Cookie->flush uses it's own cookie update mechanism.
First I added the ability of restricting session cookie path to Dancer::Session::Abstract (and fix some function calls into methods). Then I forgot to install the fix and search for some hours the test failure in upated Dancer::Session::Cookie.
This mail includes the patches for Dancer itself - follow up mail includes the patch for Dancer-Session-Cookie dist.
Would be great if you could review and/or apply or find someone who could.
Thanks in advance, Jens
PS: Happy New Year, everyone!
I'm also interested in getting Dancer::Session::Cookie ported to Dancer 2.
Would be great, even if it's not intended with the current patch/release.
I'd be willing to help as co-maintainer if current maintainers are short on tuits.
I can do the technical (coding) part.
David
Jens
participants (3)
-
David Golden -
Jens Rehsack -
Jens Rehsack