No more collisions of routes with multiple Dancer(1) apps!
Hello All, I made a changes for Dancer1! Please to see pull request of https://github.com/sukria/Dancer/pull/703 I added new option to config: routes_per_app If it is true in config routes will be work only for applications where i its defined. If not true - it works as worked before (backward compatible) I wrote a test for it All tests are passed Now i will test it in my real project If i will find a some bugs i will notice you Best regards, Perlover P.S. And dear author(s) - please approve & merge other commit too - it fix bug with request->header() - https://github.com/sukria/Dancer/pull/702
This kind of patches are actually not really what we watn to do since we have dancer2 on the way which is going to solve these collisions. A better way to help the project is to test an upgrade of your app to Dancer 2. Thanks. 2011/11/23 Perlover <perlover@perlover.com>:
Hello All,
I made a changes for Dancer1! Please to see pull request of https://github.com/sukria/Dancer/pull/703
I added new option to config: routes_per_app
If it is true in config routes will be work only for applications where i its defined. If not true - it works as worked before (backward compatible) I wrote a test for it All tests are passed
Now i will test it in my real project If i will find a some bugs i will notice you
Best regards, Perlover
P.S. And dear author(s) - please approve & merge other commit too - it fix bug with request->header() - https://github.com/sukria/Dancer/pull/702 _______________________________________________ Dancer-users mailing list Dancer-users@perldancer.org http://www.backup-manager.org/cgi-bin/listinfo/dancer-users
Hello, Thanks for reply. But I will use my own patched version of Dancer-1 (i don't have a time for adaptation for Dancer2) If you don't want patch - it's your choose of cause as of authors. Ok, lets your users will have a problems with multi apps... Bye 28.11.2011 17:42 пользователь "Alexis Sukrieh" <sukria@sukria.net> написал:
This kind of patches are actually not really what we watn to do since we have dancer2 on the way which is going to solve these collisions.
A better way to help the project is to test an upgrade of your app to Dancer 2. Thanks.
2011/11/23 Perlover <perlover@perlover.com>:
Hello All,
I made a changes for Dancer1! Please to see pull request of https://github.com/sukria/Dancer/pull/703
I added new option to config: routes_per_app
If it is true in config routes will be work only for applications where i its defined. If not true - it works as worked before (backward compatible) I wrote a test for it All tests are passed
Now i will test it in my real project If i will find a some bugs i will notice you
Best regards, Perlover
P.S. And dear author(s) - please approve & merge other commit too - it fix bug with request->header() - https://github.com/sukria/Dancer/pull/702 _______________________________________________ Dancer-users mailing list Dancer-users@perldancer.org http://www.backup-manager.org/cgi-bin/listinfo/dancer-users
Of cause, dancerctl is more important than buggy behavior of Dancer1 with plack + mount. Ok. Starts scripts of buggy soft is more important than buggy soft is run by them. But may be you are losing users of Dancer while discuss about dancerctl? I suggest easy solution - the single option on config file. It works in my project. You forward me to raw project Dancer2. Thanks. 29.11.2011 1:50 пользователь "Perlover" <perlover@perlover.com> написал:
Hello, Thanks for reply. But I will use my own patched version of Dancer-1 (i don't have a time for adaptation for Dancer2) If you don't want patch - it's your choose of cause as of authors. Ok, lets your users will have a problems with multi apps... Bye 28.11.2011 17:42 пользователь "Alexis Sukrieh" <sukria@sukria.net> написал:
This kind of patches are actually not really what we watn to do since we have dancer2 on the way which is going to solve these collisions.
A better way to help the project is to test an upgrade of your app to Dancer 2. Thanks.
2011/11/23 Perlover <perlover@perlover.com>:
Hello All,
I made a changes for Dancer1! Please to see pull request of https://github.com/sukria/Dancer/pull/703
I added new option to config: routes_per_app
If it is true in config routes will be work only for applications where i its defined. If not true - it works as worked before (backward compatible) I wrote a test for it All tests are passed
Now i will test it in my real project If i will find a some bugs i will notice you
Best regards, Perlover
P.S. And dear author(s) - please approve & merge other commit too - it fix bug with request->header() - https://github.com/sukria/Dancer/pull/702 _______________________________________________ Dancer-users mailing list Dancer-users@perldancer.org http://www.backup-manager.org/cgi-bin/listinfo/dancer-users
Perlover wrote, On 11/28/2011 07:50 PM:
Hello, Thanks for reply. But I will use my own patched version of Dancer-1 (i don't have a time for adaptation for Dancer2) If you don't want patch - it's your choose of cause as of authors. Ok, lets your users will have a problems with multi apps... Bye
I'm also interested in this patch, I think deploying with Plack::Handler::Apache2 is a very useful and quick way, and I'd love it to work with more than one application. Is it published on github ?
Hello,
I'm also interested in this patch, I think deploying with Plack::Handler::Apache2 is a very useful and quick way, and I'd love it to work with more than one application.
Is it published on github ?
Yes, of cause https://github.com/Perlover/Dancer The current branch (my/current) - only clone and install instead original Dancer There are my three patches (fixes some bugs - i requested its in my pull requests at github) It's checked and worked version based on devel branch of 1.3080 You need to add routes_per_app in your config and nothing to do. Examples in Dancer::Deployment doc It was bug not only multi-apps As i wrote it's problem for one application if we use Plack + mount. So original Dancer::Deployment example in "Running multiple apps with Plack::Builder" is potentially bad and buggy. There will be collisions of routes of app1 & app2 between mounted app1 & app2 applications. My patch works and has tests for it in distributive. But authors don't want to patch it. So welcome to my Dancer branch :)
_______________________________________________ Dancer-users mailing list Dancer-users@perldancer.org http://www.backup-manager.org/cgi-bin/listinfo/dancer-users
I think I need to clarify my views on this, and apologize as well for not expressing myslef more clearly in the first place. First things first: patches are welcome, always. Second: Dancer is free software, it relies on freetime of its maintainers. Let's try not to get upset too quickly if we can ;) Dancer 2 is going to be a major improvement, really. Many complex bugs will be fixed (like the collision one) it will run faster, be more extensible... The only thing that I wanted to say in my previous email was that: - most of the time spent nowdays is spent on 2 - Dancer 1 is "feature-frozen", in order to make the transition possible - feedback and help are very much appreciated on 2 - there is a workaround in 1 for the apps collisions This means that our priority is 2, from now on, new features wont be applied to 1, only bugfixes will be reviewed. Eventhough, I'll take some time to review your PR, but please, dont take my first email personal, understand that behind Dancer, there are human beings, with real life issues to deal with, and that can have an impact on their freetime. Thanks. Le 29 nov. 2011 à 01:50, Perlover <perlover@perlover.com> a écrit :
Hello, Thanks for reply. But I will use my own patched version of Dancer-1 (i don't have a time for adaptation for Dancer2) If you don't want patch - it's your choose of cause as of authors. Ok, lets your users will have a problems with multi apps... Bye
28.11.2011 17:42 пользователь "Alexis Sukrieh" <sukria@sukria.net> написал: This kind of patches are actually not really what we watn to do since we have dancer2 on the way which is going to solve these collisions.
A better way to help the project is to test an upgrade of your app to Dancer 2. Thanks.
2011/11/23 Perlover <perlover@perlover.com>:
Hello All,
I made a changes for Dancer1! Please to see pull request of https://github.com/sukria/Dancer/pull/703
I added new option to config: routes_per_app
If it is true in config routes will be work only for applications where i its defined. If not true - it works as worked before (backward compatible) I wrote a test for it All tests are passed
Now i will test it in my real project If i will find a some bugs i will notice you
Best regards, Perlover
P.S. And dear author(s) - please approve & merge other commit too - it fix bug with request->header() - https://github.com/sukria/Dancer/pull/702 _______________________________________________ Dancer-users mailing list Dancer-users@perldancer.org http://www.backup-manager.org/cgi-bin/listinfo/dancer-users
On Dec 1, 2011, at 12:12 PM, Alexis Sukrieh wrote:
..
Dancer 2 is going to be a major improvement, really. Many complex bugs will be fixed (like the collision one) it will run faster, be more extensible... ..
The inevitable question follows -- what is the ETA for "Dancer deux"? -- Puneet Kishor
participants (5)
-
Alexis Sukrieh -
Alexis Sukrieh -
Assaf Gordon -
Perlover -
Puneet Kishor