there is already a Dancer::Template::Mason, this plugin is intended to be a Dancer2 module.

data_dir ... I followed the original module closely, will take a look to see what happens when it isn't there.

thank you for taking a look.

On Mon, Sep 30, 2013 at 10:56 AM, Pedro Melo <melo@simplicidade.org> wrote:

Hi,

On Mon, Sep 30, 2013 at 3:29 PM, Slavik Goltser <slavikg@gmail.com> wrote:

Took a quick look yesterday, definitely going to incorporate some code.

Feel free, I don't have enough time to clean it up and push to CPAN… Two comments on your code:

* I would rename to Dancer::Template::Mason, given that the name of the module is Mason, not Mason2.

* Drop the data_dir part from your code: Mason defaults are safe enough, no need to add different semantics at this layer, the user can always make his own mind and change the config.

Bye,

--
Pedro Melo
@pedromelo
http://www.simplicidade.org/
xmpp:melo@simplicidade.org
mailto:melo@simplicidade.org

_______________________________________________
dancer-users mailing list
dancer-users@dancer.pm
http://lists.preshweb.co.uk/mailman/listinfo/dancer-users