<div dir="ltr">That sounds reasonable.<div><br></div><div>If I can help please let me know. :)</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 15, 2014 at 10:46 AM, Henk van Oers <span dir="ltr"><<a href="mailto:hvo.pm@xs4all.nl" target="_blank">hvo.pm@xs4all.nl</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
On Sun, 14 Dec 2014, Sawyer X wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This shouldn't be in the migration document since it isn't Dancer core, it's just a plugin API change. The plugin should indicate it.<br>
I also support removing the stringification. If a warning is to produced, it means stringification should either be allowed with a warning, or cause a croak instead.<br>
<br>
Henk, what do you think?<br>
</blockquote>
<br></span>
I don't know how many D1 users use the stringification.<br>
To ease the migration I would like:<br>
<br>
- allow stringification with a 'warn' call<br>
- a deprecation note in the documentation<br>
- new version 2.0.6<br>
- remove the stringification in version 3.0.0<br>
<br>
-- Henk<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
On Sun, Dec 14, 2014 at 1:36 PM, Gabor Szabo <<a href="mailto:gabor@szabgab.com" target="_blank">gabor@szabgab.com</a>> wrote:<br></span>
IMHO stop the stringification (with some warning) and remove it from the pod as well.(and add it to the Migration document as well).<div><div class="h5"><br>
Gabor<br>
<br>
<br>
On Sun, Dec 14, 2014 at 2:27 PM, Sawyer X <<a href="mailto:xsawyerx@gmail.com" target="_blank">xsawyerx@gmail.com</a>> wrote:<br>
You're right. I removed the stringification when redoing the API. I didn't return it and the docs still retain that message.<br>
I'm still not sure whether it should stringify. That's always a source of trouble.<br>
<br>
We could stringify with a deprecation or just keep it.<br>
What is your opinion?<br>
(other than that the docs should be up-to-date :)<br>
<br>
<br>
On Sun, Dec 14, 2014 at 11:46 AM, Gabor Szabo <<a href="mailto:gabor@szabgab.com" target="_blank">gabor@szabgab.com</a>> wrote:<br>
Actually, I just noticed the documentation of both modules (Dancer:: and Dancer2::) have this in their pod:<br>
"For convenience the object will automagically return the RFC 2307 representation when no method is called on it."<br>
<br>
Which means it should still stringify to the rfc2307 value.<br>
<br>
Gabor<br>
<br>
<br>
On Sun, Dec 14, 2014 at 11:26 AM, Gabor Szabo <<a href="mailto:gabor@szabgab.com" target="_blank">gabor@szabgab.com</a>> wrote:<br>
Finally I got to the point where I was actually testing the part where Dancer2::Plugin::Passphrase is used and I think<br>
I there is a change from the API of Dancer::Plugin::Passphrase<br>
<br>
It seems that the 'generate' method of the new module return a Dancer2::Plugin::Passphrase::<u></u>Hashed object<br>
and does not stringify to the rfc2307 value as happened in the case of the Dancer1 version.<br>
<br>
Looking at the documentation I see both say that I should store the ->rfc2307 value, but because of the stringification I have missed<br>
that earlier.<br>
<br>
If you decided to not include the stringification, then maybe this should be emphasized in the docs as well.<br>
<br>
Gabor<br>
<br>
<br>
<br>
<br>
<br>
______________________________<u></u>_________________<br>
dancer-users mailing list<br>
<a href="mailto:dancer-users@dancer.pm" target="_blank">dancer-users@dancer.pm</a><br>
<a href="http://lists.preshweb.co.uk/mailman/listinfo/dancer-users" target="_blank">http://lists.preshweb.co.uk/<u></u>mailman/listinfo/dancer-users</a><br>
<br>
<br>
<br>
</div></div></blockquote><div class="HOEnZb"><div class="h5">
______________________________<u></u>_________________<br>
dancer-users mailing list<br>
<a href="mailto:dancer-users@dancer.pm" target="_blank">dancer-users@dancer.pm</a><br>
<a href="http://lists.preshweb.co.uk/mailman/listinfo/dancer-users" target="_blank">http://lists.preshweb.co.uk/<u></u>mailman/listinfo/dancer-users</a><br>
</div></div></blockquote></div></div>