<div dir="ltr">Hi Henk!<div><br></div><div>I haven't replied for a while because I have been sitting and working on the plugin.</div><div><br></div><div>The main problem was the overload. It was screwing up stuff. It took a while to find.</div><div><br></div><div>Another problem is the awkward API here, which I think needs to be changed. It's an object but not an object. It has overloading but registers keywords. It has a few mutable options and some places in which they are immutable.</div><div><br></div><div>Because it's still not 100% working (because of this API I don't have the time to wrangle into proper behavior), I haven't submitted a pull request for all the fixes so far.</div><div><br></div><div>I'm willing to rework the API and make it consistent, resolving the issues and providing a full pull request, but I won't do it unless I know you're okay with it.</div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Nov 23, 2014 at 1:39 PM, Henk van Oers <span dir="ltr"><<a href="mailto:henk@signature.nl" target="_blank">henk@signature.nl</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
Good morning Sawyer,<br>
<br>
The repo: <a href="https://github.com/hvoers/Dancer2-Plugin-Passphrase" target="_blank">https://github.com/hvoers/<u></u>Dancer2-Plugin-Passphrase</a><br>
<br>
Thanks for taking a look.<span><font color="#888888"><br>
<br>
Henk.<br>
<br>
-- <br></font></span><span>
<br>
<br>
On Sun, 23 Nov 2014, Sawyer X wrote:<br>
<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>
I meant the repo.<br>
I just woke up, give me a break. :)<br>
<br></span><div><div>
On Sun, Nov 23, 2014 at 1:03 PM, Kov?cs D?vid [ Davs ] <<a href="mailto:davserer@gmail.com" target="_blank">davserer@gmail.com</a>> wrote:<br>
<a href="https://metacpan.org/pod/Dancer2::Plugin::Passphrase" target="_blank">https://metacpan.org/pod/<u></u>Dancer2::Plugin::Passphrase</a> Is this it?<br>
<br>
On Sun, Nov 23, 2014 at 1:00 PM, Sawyer X <<a href="mailto:xsawyerx@gmail.com" target="_blank">xsawyerx@gmail.com</a>> wrote:<br>
This is because you're calling plugin_setting() in the wrong context.<br>
Where is the code? :)<br>
<br>
On Sun, Nov 23, 2014 at 11:00 AM, Henk van Oers <<a href="mailto:hvo.pm@xs4all.nl" target="_blank">hvo.pm@xs4all.nl</a>> wrote:<br>
<br>
In Dancer2-Plugin-Passphrase I have this test:<br>
<br>
--- 003_default_settings.t ---<br>
use Test::More tests => 3;<br>
<br>
use strict;<br>
use warnings;<br>
<br>
use Dancer2;<br>
use Dancer2::Plugin::Passphrase;<br>
<br>
my $secret = "Super Secret Squirrel";<br>
<br>
my $rfc2307 = passphrase($secret)->generate-<u></u>>rfc2307;<br>
<br>
like($rfc2307, qr/^{CRYPT}\$2a\$04\$/, 'RFC compliant hash generated');<br>
ok(passphrase($secret)-><u></u>matches($rfc2307), 'Match plaintext to hash');<br>
ok(!passphrase('WRONG')-><u></u>matches($rfc2307), 'Incorrect passwords should be rejected');<br>
<br>
--- ---<br>
<br>
CPANtesters use the latest D2,<br>
which contains a "croak 'No DSL object found'"<br>
<br>
See:<br>
<a href="http://www.cpantesters.org/cpan/report/d4473e02-7246-11e4-ac74-95bbe0bfc7aa" target="_blank">http://www.cpantesters.org/<u></u>cpan/report/d4473e02-7246-<u></u>11e4-ac74-95bbe0bfc7aa</a><br>
<br>
How do I add a DSL to this test?<br>
<br>
Thanks,<br>
Henk<br>
</div></div></blockquote><div><div>
______________________________<u></u>_________________<br>
dancer-users mailing list<br>
<a href="mailto:dancer-users@dancer.pm" target="_blank">dancer-users@dancer.pm</a><br>
<a href="http://lists.preshweb.co.uk/mailman/listinfo/dancer-users" target="_blank">http://lists.preshweb.co.uk/<u></u>mailman/listinfo/dancer-users</a><br>
</div></div></blockquote></div><br></div></div>