<div dir="ltr">Actually, the whole thing is that dancer_version (or major_version) should clearly not be used for plugins to check their compatibility with the core. Actually, what plugin should do is to use api_version.<div>
<br></div><div style>Simple example :</div><div style><br></div><div style>Dancer 1.9999_01 is "Dancer 1" is you look at the VERSION (whatever method you choose) but it's actually "Dancer 2" regarding its core.</div>
<div style><br></div><div style>So to summarize:</div><div style><br></div><div style> - dancer_major_version should be removed, it has been added in a rush, while releasing 1.9999_01 but was a mistake because of the reason explained above</div>
<div style> - api_version should be used whenever something needs to check its compatibility with the core </div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2012/12/25 damien krotkine <span dir="ltr"><<a href="mailto:dkrotkine@gmail.com" target="_blank">dkrotkine@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div>Hi,</div><div><br></div><div>As I understand, Alexis did a dev release of dancer2. The version is 1.9999_01 or something like that.</div>
<div><br></div><div>People and plugins currently uses int(dancer_version) to discover if it's running under Dancer 1 or Dancer 2.</div>
<div><br></div><div>int(1.0000_01) emits a warnings, so to work around that, a ne keyword has been added :</div><div><br></div><div>dancer_major_version, which returns what's on the left of the dot in the version number.</div>
<div><br></div><div>Fine, except that : </div><div>- this keyword has not been added to Dancer v1, so plugins using dancer_major_version will break under Dancer 1<br></div><div>- no advertizing has been made on to what plugins should use (ie continue using int() or use the new keyword)</div>
<div><br></div><div>What's the best solution ?</div><div><br></div><div>In my opinion we can :</div><div>1/ Release a new Dancer 1, and ask people to use dancer_major_version and require the latest Dancer 1 release (or Dancer 2) : long and cumbersome as we need to potentially modify plugins and contact users and so all</div>
<div><br></div><div>2/ remove dancer_major_version, and change dancer_version so that it returns the version without the _xx at the end. Simple, doesn't need to release D1 again, and nothing to change in plugins.</div>
<div><br></div><div>3/ any idea ?</div><div><br></div><div>As you may guess, I'm a big fan of solution 2. If you all agree (especially sukria, as he added dancer_major_version, and maybe he had an other reasons for that), I can make the change.</div>
<div><br></div><div>In my opinion, the longer we stay in the current situation (dancer_major_version only in D2), the more dangerous it is</div><div><br></div><div>dams.</div><div><br></div><div>
<br></div></div>
<br>_______________________________________________<br>
dancer-dev mailing list<br>
<a href="mailto:dancer-dev@dancer.pm">dancer-dev@dancer.pm</a><br>
<a href="http://lists.preshweb.co.uk/mailman/listinfo/dancer-dev" target="_blank">http://lists.preshweb.co.uk/mailman/listinfo/dancer-dev</a><br>
<br></blockquote></div><br></div>